LONDON | MAY | KOKUL | WIREFRAME #665
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Both of your PRs do not have a "Needs review" label. As such, the volunteers won't recognise them as being "ready to be reviewed". Until you're able to add a label, here are some actions you can take to further improve your implementation and your PR (in order to speed up the review process):
Then take a look at the suggestions it gives you, and pick out the ones that actually make sense for your project. It's a also great way to learn and improve your work. |
Kokul-vathany
changed the title
There was a problem hiding this comment.
Code is error free. Good job.
-
When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you align the high of the images in the last two articles?
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means or look up what "viewport" means).
-
Can you improve the Lighthouse Accessibility score of your page to 100?
-
To follow best practices, can you carry out the following actions?
- Check the items in the Self-Checklist to confirm your pull request meets the guidelines
- Provide a brief description (under the "Changelist" section) summarizing the purpose of the PR and the changes you’ve made
| voluptates. Quisquam, voluptates. | ||
| The primary purpose of a wireframe is to outline the basic structural design and user experience of a website or application before any detailed design work is done. It's a visual representation of the layout, content, and functionality, helping designers, developers, and stakeholders understand the overall structure and flow. |
There was a problem hiding this comment.
The long text line at line 21 can be better formatted as:
The primary purpose of a wireframe is to outline the basic structural
design and user experience of a website or application before any
detailed design work is done. It's a visual representation of the
layout, content, and functionality, helping designers, developers, and
stakeholders understand the overall structure and flow.
To understand why, you can ask ChatGPT these questions:
- How HTML treat mutliple whitespace characters in text?
- What's the advantage of not writing a long paragraph of text in a single line in HTML?
VSCode's "Format Document" feature can help us format our code for better readability and consistency, including breaking a long line of text into shorter lines of text.
To use the feature, right-click inside the code editor and select the option.
Please note that if there are syntax errors in the code, the "Prettier" extension may not format HTML code properly.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.